catnip: init: remove rte_eth_rss_ip call from rss_hf init #1630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m running Demikernel with the catnip LibOS on an Intel 82599ES NIC, and DPDK initialization currently fails due to an invalid rss_hf value. The rte_eth_rss_ip() helper appears to enable RSS hash types that are not supported by this NIC, which causes rte_eth_dev_configure() to return an error. This change removes the rte_eth_rss_ip() call so that the configuration does not request unsupported RSS features on 82599ES